-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add async execution tutorials #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit 3501c76 https://deploy-preview-1045--pytorch-tutorials-preview.netlify.app |
cc @jlin27 |
9db4d8f
to
42dcdf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few commments.
side, when getting the ``Future`` object, it installs subsequent RPC response | ||
preparation and communication as callbacks as well, which will be triggered | ||
when the final result is ready. In this way, the callee no longer needs to block | ||
one thread and wait until the final return value is ready Please refer to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "." after ready
|
||
The rest of the code is normal processes launching and logging which are | ||
similar to other RPC tutorials. In this tutorial, all observers passively | ||
waiting for commands from the agent. please refer to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Please"
|
||
|
||
.. figure:: /_static/img/rpc-images/batch.png | ||
:alt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add a "Learn More" section at the end that links out resources users can follow to continue their learnings on this topic (e.g. RPC Examples: ttps://github.com/pytorch/examples/tree/master/distributed/rpc/batch, the next tutorial, etc).
No description provided.