Skip to content

Address comments on Dist Profiling Recipe #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

rohan-varma
Copy link
Member

@rohan-varma rohan-varma commented Jul 15, 2020

Addresses @mrshenli 's comments on #1068

@netlify
Copy link

netlify bot commented Jul 15, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 6457b99

https://deploy-preview-1073--pytorch-tutorials-preview.netlify.app

@brianjo
Copy link
Contributor

brianjo commented Sep 16, 2020

@rohan-varma Could rebase this? I'll merge it as soon as it passes tests.

@rohan-varma rohan-varma reopened this Sep 16, 2020
@rohan-varma
Copy link
Member Author

@brianjo I couldn't find the file "distributed_rpc_profiling.rst" in master or in pytorch/release:1.6 anymore - do you or @jlin27 know where it went? Anyways, I added it back in this PR.

@jlin27
Copy link
Contributor

jlin27 commented Sep 16, 2020

It's under the prototype_source folder: https://github.com/pytorch/tutorials/tree/master/prototype_source

Starting with the 1.6 release, all tutorials with features marked prototype were added into this folder so that they wouldn't show up on the website. The rationale is that prototype features are based off of unstable code so we didn't want users running across prototype tutorials and expecting them to work based off of stable code. Only more experienced users who knew about the feature would be able to reference these hidden tutorials.

The idea was that once the feature was no longer prototype, it would be "graduated" out of that folder into (into intermediate_source or one of the other sources).

@brianjo
Copy link
Contributor

brianjo commented Sep 16, 2020

OK I'm going to merge this one and remove the prototype file. Thanks @jlin27!

@brianjo brianjo merged commit 42a4f0b into pytorch:release/1.6 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants