Skip to content

Add parameter and return types #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2022
Merged

Add parameter and return types #59

merged 2 commits into from
May 9, 2022

Conversation

pacoorozco
Copy link
Contributor

@pacoorozco pacoorozco commented Mar 4, 2022 •
edited
Loading

I've added parameter and return types to all the methods.

NOTE: I think there's a bug in the imageUrl() method when it's calling getFileUploadPath($field) but I've not been able to fix it.

Resolves #52
Resolves #57
Resolves #58

@pacoorozco
Fix missing parameter and return types
63dbbc7 
Signed-off-by: pacoorozco <paco@pacoorozco.info>
@pacoorozco
Add condition to avoid call deleteImage() w/ empty filename
d042160 
Signed-off-by: pacoorozco <paco@pacoorozco.info>
@pacoorozco
Copy link
Contributor Author

Merging that PR, maybe the #58 is not needed because this supersedes the workaround on the #58.

@syofyanzuhad
Copy link

Please merge this update to master @pacoorozco

@pacoorozco
Copy link
Contributor Author

I can't I don't have wit write access

@syofyanzuhad
Copy link

I can't I don't have wit write access

oowh i think you're the maintainer.. 😅
so somebody please merge this PR @saqueib

@dmitriymikheev
Copy link
Contributor

Hi, can somebody merge this, guys? @saqueib @shadoWalker89 @joaorobertopb @tomredhot

@saqueib saqueib merged commit da1bb0b into qcod:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@pacoorozco @syofyanzuhad @dmitriymikheev @saqueib