Skip mypy check in CI #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added october to custom dictionary as it failed spell check <reno.sphinxext current branch>:29: : Spell check: october: in October 2024 and is no longer being maintained. If you were. |
Pull Request Test Coverage Report for Build 13839602999Details
💛 - Coveralls |
|
The CI tasks,, which run against (monitor) Qiskit main branch to ensure it continues to work for new releases is failing. This is due to algorithms still using V1 primitives. I imagine that once that is released things will fail here - a pin for Qiskit < 2.0 could be added now, which would avoid that preemptively. I guess that can be done in a separate PR too, like adding 3.13 Python support as noted above. |
ElePT
reviewed
Mar 13, 2025
ElePT
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently CI is failing mypy checks, It seems this happens with the latest numpy version (2.2.x and above) that has changed things
I chose to simply disable the mypy checks for now as there are many errors that would need sorting to keep mypy checks in place. It would be possible to limit numpy in CI here to < 2.2, where it still passes fine, but I chose instead to have the latest numpy installed so its unit tested with that.
Details and comments
See #218 (comment) for more information.
I created #222 as a reminder this has been done so potentially mypy checks can be re-instated at some future point.
#74 also talks about type improvements
I see now CI is failing with 3.8 where its trying to build a wheel for qiskit-aer. As Python 3.8 reached EOL in October 2024 and is no longer maintained I am removing it as a supported version and hence from CI. I added an upgrade release note accordingly.
closes #201
Note: I have not updated the branch protection rules, which include CI runs done on 3.8, so for now CI will still show these as required but they will not be run. If this is all ok I will update the rules.
Note: while this is adjusting supported Python versions it is only doing so as CI is failing on 3.8 and this PR is to get CI running again. Hence while it could be adjusted more, ie add 3.13 assuming it passes tests. I think that's better done in a separate PR.
I have added a pin to Qiskit < 2.0 to ensure that it installs a version of qiskit where it will work given that the V1 primitives, which qiskit algorithms uses, have been deprecated and are removed in Qiskit 2.0
See below #221 (review)
I updated the logic that tests against Qiskit main branch as it installed the code from main then installed algorithms. With the upper version of qiskit pinned, as it is now, that ended up installing a version that matched the pin in the install algs step so in effect "undid" the install from main. The intent has been to check the code against main to have a heads up to changes etc. So I swapped the order to install algorithms first, then qiskit from main branch (uninstalling qiskit in between so as we end up with the install from main qiskit and that is not altered by having some version installed already).