More render tests #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1f265d to
eb4dd18
Compare
eb4dd18 to
1d7f2ab
Compare
|
Not sure why the existing tests png images were changed. Is that required. They were smaller (optimized), btw. Could you remove those changes, please? The actual changes look good, but I would prefer to keep the opacity for now until we decide on that one. Would it be fine to you if I would rebase this, remove changes present in #84 (those could be discussed separately) and add opacity for now? |
| @@ -19,4 +19,10 @@ describe('QMLEngine.scope', function() { | |||
| expect(parentItem.sum).toBe(6600); | |||
| div.remove(); | |||
| }); | |||
|
|
|||
| it('can reference sibling items by id', function() { | |||
| var qml = loader('Parent', this.div); | |||
There was a problem hiding this comment.
should be loader(´Sibling´... good your eyes are working at least
1ffa6dd to
d8847c2
Compare
|
cleaned up and rebased, @ChALkeR, @pavelvasev, @Plaristote LGTY? |
PR-URL: #88 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
d8847c2 to
1183986
Compare
|
Rebased against master, optimized images, minor style fixes. |
|
Ok, LGTM. Landing. |
igosoft
pushed a commit
that referenced
this pull request
Mar 6, 2016
PR-URL: #88 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #84
adds tests for anchoring,
AnchorsFill.qml fails, probably because it references a sibling.