[S1161] use `staticanalysis.MissingOverrideAnnotation` to avoid missing `@Override` on overriding and implementing methods #48344

Pankraz76 · 2025-06-12T08:45:40Z

[S1161] fix build setup to avoid missing @Override on overriding and implementing methods by consolidating rewrite and spotless.

While its not required, it still seems best practice to do so.

take advantage of the compiler check:

https://stackoverflow.com/a/94411

refs:

quarkus-bot · 2025-06-12T08:46:18Z

/cc @ebullient (metrics), @jmartisk (metrics)

quarkus-bot · 2025-06-12T08:46:19Z

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

title should preferably start with an uppercase character (if it makes sense!)

_{This message is automatically generated by a bot.}

Pankraz76 · 2025-06-12T08:48:43Z

is there any chance you can incorporate such low prio but big impact, selfcare topic? @geoand

if you want to gain this increment and solve this flaws there is the need for static analysis.

As you seem to be complain with rewrite this seems the best fit to reduce this kind of avoidable friction.

ether by continue to ignore or to recognize and fix.

geoand · 2025-06-12T08:55:14Z

I'm traveling, so I haven't been able to look at anything that takes more than a few minutes

Pankraz76 · 2025-06-12T09:01:12Z

build now fixed flaws just like white spaces:

Pankraz76 · 2025-06-12T09:12:26Z

@gastaldi is this any good?

build-parent/pom.xml

core/launcher/src/main/java/io/quarkus/launcher/RuntimeLaunchClassLoader.java

Pankraz76 · 2025-06-12T10:14:35Z

hi @gsmet,

kindly request your call on this.

the parent seems to have all config already like expected. So the 9 times extra seems to be obsolete as all even the independent have luckily SSOT sharing same parent.

if one gets called, all should like sharing same root:

Pankraz76 · 2025-06-12T13:02:17Z

independent-projects/parent/pom.xml

@@ -15,8 +15,29 @@

    <packaging>pom</packaging>

+    <!-- please keep in alphabetical order -->


only plugin can handle this.

https://github.com/Ekryd/sortpom

Pankraz76 · 2025-06-12T19:43:16Z

.github/dependabot.yml

-      - dependency-name: net.revelc.code.formatter:formatter-maven-plugin
-      - dependency-name: net.revelc.code:impsort-maven-plugin
+      - dependency-name: org.openrewrite.maven:rewrite-maven-plugin
+      - dependency-name: com.diffplug.spotless:spotless-maven-plugin


Add Support for Eclipse Code Formatter openrewrite/rewrite#4578

it would be great to only use rewrite and include eclipse format, currently implemented with formatter-maven-plugin/spot, into rewrite by supporting new format.

https://github.com/ndimiduk/spring-framework/blob/master/eclipse-code-formatter.xml

@timtebeek

Pankraz76 · 2025-06-12T21:21:13Z

devtools/maven/src/main/java/io/quarkus/maven/components/Prompter.java

@@ -48,12 +48,10 @@ public void collectInput() throws IOException {
            return;
        }
        final TerminalConnection connection = new TerminalConnection();
-        connection.setSignalHandler(interruptionSignalHandler());
-        try {


use try-with-resources statement openrewrite/rewrite-static-analysis#591

use try-with-resources statement in LookupWagonMojo apache/maven#2426

Pankraz76 · 2025-06-13T09:46:25Z

.github/dependabot.yml

@@ -86,8 +86,8 @@ updates:
      - dependency-name: org.apache.maven.plugins:*
      - dependency-name: org.codehaus.mojo:*
      - dependency-name: io.fabric8:docker-maven-plugin
-      - dependency-name: net.revelc.code.formatter:formatter-maven-plugin


spot is already added only for kotlin but not used.

As spot is covering the impsort-maven-plugin as well, we can have 2 for 1 plugin meaning only spot for having current functionality.

rewrite then goes beyond whitespaces fixing real issues and flaws.

Is this a way to go for the dev team?

This will integrate silent without breaking current workflow, but even fixing any.

@gsmet

assuming as already in touch

quarkus/independent-projects/tools/devtools-common/src/main/resources/openrewrite-init.gradle

Line 10 in 3060ddd

classpath("org.openrewrite:plugin:{pluginVersion}")

the leal topic (licence) is not involved, right?
or does the plugin usage interfere anything? @timtebeek

the leal topic (licence) is not involved, right?
or does the plugin usage interfere anything?

I fail to understand what you mean by this comment; can you provide more context when tagging folks?
It's hard to drop in somewhere and then having to parse a whole lot when you want my input on something.

yes sorry.

does the licence of rewrite effect on quarkus, when using the plugin?

So up to now, after some friendly coordination late last year, the folks at Quarkus are only using Apache Licensed components of OpenRewrite, such as the rewrite-maven-plugin, rewrite-core/java, rewrite-java-dependencies and of course rewrite-quarkus.

In this PR you look to be adding rewrite-static-analysis in independent-projects/parent/pom.xml as a build plugin. That would still be very much allowed by our licensing terms, but different teams have different tastes for exposure to other-than-traditional OSS licenses, even if it's just a build dependency.

From my earlier chats with the folks at Quarkus/Red Hat I'd say it's likely they'd be appreciative of the code changes made by recipes, but perhaps not willing to make rewrite-static-analysis part of their build pipeline. Any Apache Licensed recipes would not have any such hurdles to clear. I can't speak for them of course; just telling you what I'd expect.

Thanks for the detailed exposition.

allowed by our licensing terms

So the licence seems not to be an issue, giving the ability to leverage rewrite-maven-plugin.

Is there an limit to only use rewrite-static-analysis, or could we use all the other goodness, as well?

Like rewrite-testing-frameworks, rewrite-rewrite highlighting bestpractices, as there are several different around.

https://docs.openrewrite.org/recipes/java/testing/cleanup/bestpractices

https://docs.openrewrite.org/recipes/java/recipes/javarecipebestpractices

Treat the plugin as found- and limitation.

The licenses for every module are listed here:

https://docs.openrewrite.org/reference/latest-versions-of-every-openrewrite-module

The terms for the various licenses are here, with a clear FAQ at the end as well:

https://docs.openrewrite.org/licensing/openrewrite-licensing

In short the folks here (and other end users in general) are welcome to use any of the Apache or MSAL modules for their own code and purposes.

…OverRide

…OverRide on overriding and implementing methods

gsmet

License of the module is not acceptable for the Quarkus build.

Pankraz76 · 2025-06-15T08:57:09Z

Thanks for update.

Then only alternative seems PMD to achieve common baseline:

https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#missingoverride

Autofix is nice so have. Rewrite took too long anyways so it would be very hard to integrate considering the runtime gain of 1h plus.

Pankraz76 force-pushed the missing-override branch from 8956760 to 39b82d5 Compare June 12, 2025 09:11

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 12, 2025

Pankraz76 force-pushed the missing-override branch from 39b82d5 to cceddb5 Compare June 12, 2025 09:17

Pankraz76 commented Jun 12, 2025

View reviewed changes

build-parent/pom.xml Outdated Show resolved Hide resolved

Pankraz76 commented Jun 12, 2025

View reviewed changes

core/launcher/src/main/java/io/quarkus/launcher/RuntimeLaunchClassLoader.java Outdated Show resolved Hide resolved

Pankraz76 mentioned this pull request Jun 12, 2025

[S1161] Add missing @Override to overriding and implementing methods #48345

Closed

Pankraz76 mentioned this pull request Jun 12, 2025

removeUnused not working revelc/impsort-maven-plugin#139

Closed

Pankraz76 force-pushed the missing-override branch from 8e90b1a to 8b049e5 Compare June 12, 2025 11:11

quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jun 12, 2025

quarkus-bot bot added area/hibernate-reactive Hibernate Reactive area/panache area/qute The template engine labels Jun 12, 2025

Pankraz76 commented Jun 12, 2025

View reviewed changes

quarkus-bot bot added the area/maven label Jun 12, 2025

Pankraz76 commented Jun 12, 2025

View reviewed changes

Pankraz76 force-pushed the missing-override branch from ed5e10c to a453ea9 Compare June 12, 2025 21:20

Pankraz76 commented Jun 12, 2025

View reviewed changes

quarkus-bot bot added area/mailer area/scheduler area/testing area/tracing area/websockets labels Jun 12, 2025

Pankraz76 marked this pull request as ready for review June 12, 2025 21:22

Pankraz76 commented Jun 13, 2025

View reviewed changes

Pankraz76 changed the title ~~[S1161] fix build setup to avoid missing @Override on overriding and implementing methods by consolidating rewrite and spotless~~ [S1161] migrating rewrite and spotless to avoid missing @Override on overriding and implementing methods Jun 13, 2025

Pankraz76 force-pushed the missing-override branch from a453ea9 to 68edb09 Compare June 13, 2025 13:01

Pankraz76 changed the title ~~[S1161] migrating rewrite and spotless to avoid missing @Override on overriding and implementing methods~~ [S1161] use rewrite to avoid missing @Override on overriding and implementing methods Jun 14, 2025

Pankraz76 marked this pull request as draft June 14, 2025 10:53

Pankraz76 mentioned this pull request Jun 14, 2025

PoC: Remove unused imports #48050

Closed

Pankraz76 changed the title ~~[S1161] use rewrite to avoid missing @Override on overriding and implementing methods~~ [S1161] use org.openrewrite.staticanalysis.MissingOverrideAnnotation to avoid missing @Override on overriding and implementing methods Jun 14, 2025

[S1161] use staticanalysis.MissingOverrideAnnotation to avoid missing @…

ee17500

…OverRide on overriding and implementing methods

Pankraz76 force-pushed the missing-override branch from 7d56b32 to ee17500 Compare June 14, 2025 11:15

gsmet requested changes Jun 14, 2025

View reviewed changes

gsmet closed this Jun 14, 2025

quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 14, 2025

This was referenced Jun 15, 2025

[S1161] use PMD to avoid missing @Override on overriding and implementing methods #48392

Closed

quarkus-core: runtimeannotations #45897

Closed

		@@ -15,8 +15,29 @@

		<packaging>pom</packaging>

		<!-- please keep in alphabetical order -->

[S1161] use staticanalysis.MissingOverrideAnnotation to avoid missing @Override on overriding and implementing methods #48344

[S1161] use staticanalysis.MissingOverrideAnnotation to avoid missing @Override on overriding and implementing methods #48344

Uh oh!

Conversation

Pankraz76 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quarkus-bot bot commented Jun 12, 2025

Uh oh!

quarkus-bot bot commented Jun 12, 2025

Uh oh!

Pankraz76 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoand commented Jun 12, 2025

Uh oh!

Pankraz76 commented Jun 12, 2025

Uh oh!

Pankraz76 commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsmet left a comment

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Jun 15, 2025

Uh oh!

Uh oh!

[S1161] use `staticanalysis.MissingOverrideAnnotation` to avoid missing `@Override` on overriding and implementing methods #48344

[S1161] use `staticanalysis.MissingOverrideAnnotation` to avoid missing `@Override` on overriding and implementing methods #48344

Pankraz76 commented Jun 12, 2025 •

edited

Loading

Pankraz76 commented Jun 12, 2025 •

edited

Loading

Pankraz76 commented Jun 12, 2025 •

edited

Loading

Pankraz76 Jun 13, 2025 •

edited

Loading