Correct functional.py _compute_metric #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct functional.py _compute_metric when reduction == "weighted"
qubvel
requested changes
Nov 11, 2022
| tp = tp.sum(0) | ||
| fp = fp.sum(0) | ||
| fn = fn.sum(0) | ||
| tn = tn.sum(0) | ||
| score = metric_fn(tp, fp, fn, tn, **metric_kwargs) | ||
| score = _handle_zero_division(score, zero_division) | ||
| score = (score * class_weights).mean() | ||
|
|
There was a problem hiding this comment.
What is the difference with "macro"?
There was a problem hiding this comment.
sum() versus mean() as far as I can see
There was a problem hiding this comment.
@JulienMaille Exactly.
sum() instead of mean() when reduction=="weighted", and class_weights are provided and not set to 1.
There was a problem hiding this comment.
then, I guess we have to ensure that sum of class weights is equal to 1, or at least warn it that is not true
There was a problem hiding this comment.
line 254 normalizes the provided weights, so it has to sum to one:
class_weights = class_weights / class_weights.sum()
what do you think ?
There was a problem hiding this comment.
Yeah, that's right, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct functional.py _compute_metric when reduction == "weighted"