New DebugReporter #470
Merged
New DebugReporter #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 7, 2016 23:24
sink(stdout()) behaves strangely if no sink is active
- also fix off-by-one error in original implementation of recover() - also ignore options that turn recover() behavior off
- mock browse_frame() which is called from our recover() - record the frame that would have been used for the browser() call - list variables defined in that frame, compare with expectation
Current coverage is 50.98%@@ master #470 diff @@
==========================================
Files 45 46 +1
Lines 1360 1379 +19
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1126 703 -423
- Misses 234 676 +442
Partials 0 0
|
| ) | ||
| ) | ||
|
|
||
| # Copied from utils::recover() |
There was a problem hiding this comment.
Can you please also copy the copyright statement? It might be better to move into completely a new file. Will also need to update Authors@R to reference R core
added 9 commits
July 4, 2016 02:22
to support in-place handling even for stack overflow
fc47b5a to
c2881c3
Compare
c2881c3 to
7c79e9d
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls a better version of
recover()that shows only the interesting part of the call stack. Fully tested.Fixes #360.