Refactoring #190
Merged
Refactoring #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This refactoring replaces the old Graph and StoreState types with explicit dependencies and children collections on AtomStore and updates Snapshot accordingly.
- Inline the dependency graph and state fields into
AtomStore - Update
Snapshotto holddependencies/childreninstead of aGraph - Revise tests to use the new store fields and updated
Snapshotinitializer
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Atoms/Snapshot.swift | Replaced graph with dependencies & children; updated description and graph generation |
| Sources/Atoms/AtomStore.swift | Removed Graph/StoreState; added dependencies, children, caches, states, subscriptions, subscribed, scopes |
| Sources/Atoms/Core/StoreContext.swift | Switched all store.state.* and store.graph.* to direct fields |
| Sources/Atoms/Core/TopologicalSort.swift | Updated traversal to use children and subscriptions properties |
| Sources/Atoms/Core/Graph.swift | Removed the now-unused Graph struct |
| Tests/AtomsTests/**/* | Updated snapshots, assertions, and store references to use new fields |
Comments suppressed due to low confidence (4)
Sources/Atoms/Snapshot.swift:26
- The
descriptionmethod omits thesubscriptionsfield. Consider adding- subscriptions: \(subscriptions)so the textual snapshot includes all its properties.
- caches: \(caches)
Sources/Atoms/Snapshot.swift:78
- [nitpick] The local variable
childrenshadows thechildrenproperty, which may confuse readers. Consider renaming the local binding (e.g. tochildKeys).
if let children = children[key] {
Sources/Atoms/Core/TopologicalSort.swift:22
- [nitpick] This local
childrenshadows the store'schildrenproperty. Renaming it (e.g.childKeys) would improve clarity.
if let children = children[key] {
Tests/AtomsTests/SnapshotTests.swift:26
- This
Snapshotcall is missing thechildrenparameter; the initializer requires bothdependenciesandchildren. Add achildren: [...]argument to match the new signature.
dependencies: [
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type