Remove APIs deprecated in 0.7.x #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors AtomScope by removing deprecated APIs and legacy inheritance handling from version 0.7.x. The key changes include:
- Removal of the Inheritance enum and the initializer using an AtomViewContext.
- Replacement of inheritance logic with a unified scopeID-based approach.
- Simplification of observer and override registration by eliminating conditional checks.
Comments suppressed due to low confidence (2)
Sources/Atoms/AtomScope.swift:31
- Update the documentation comments for AtomScope to remove references to legacy inheritance behavior and deprecated initializers, clarifying that all functionality now uses the scopeID-based approach.
private let scopeID: ScopeID
Sources/Atoms/AtomScope.swift:116
- Since the Inheritance enum and WithEnvironment view have been removed, ensure that any inline documentation or external references are updated to prevent confusion about the current atom scope handling.
final class State: ObservableObject {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type