Skip to content

Require MQTT feature flags in 4.0 #11642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

Require MQTT feature flags in 4.0 #11642

merged 1 commit into from
Jul 10, 2024

Conversation

ansd
Copy link
Member

@ansd ansd commented Jul 9, 2024 •
edited
Loading

Since feature flag message_containers introduced in 3.13.0 is required in 4.0, we can also require all MQTT feature flags (since they were introduced in or before 3.13.0) and remove their compatibility code:

  • delete_ra_cluster_mqtt_node
  • rabbit_mqtt_qos0_queue
  • mqtt_v5

@ansd ansd force-pushed the ff_delete_ra_cluster_mqtt_node branch from 6f95096 to c9d5e1d Compare July 9, 2024 15:08
@ansd ansd changed the title Require feature flag delete_ra_cluster_mqtt_node Require MQTT feature flags in 4.0 Jul 9, 2024
@ansd
Require MQTT feature flags in 4.0
b6539bd 
Require all MQTT feature flags and remove their compatibility code:
* delete_ra_cluster_mqtt_node
* rabbit_mqtt_qos0_queue
* mqtt_v5

These feature flags were introduced in or before 3.13.0.
@ansd ansd force-pushed the ff_delete_ra_cluster_mqtt_node branch from c9d5e1d to b6539bd Compare July 9, 2024 16:19
@ansd ansd marked this pull request as ready for review July 10, 2024 07:35
@ansd ansd added this to the 4.0.0 milestone Jul 10, 2024
@ansd ansd merged commit 50116f0 into main Jul 10, 2024
250 checks passed
@ansd ansd deleted the ff_delete_ra_cluster_mqtt_node branch July 10, 2024 08:28
@ansd ansd mentioned this pull request Jul 10, 2024
Merged
ansd added a commit that referenced this pull request Jul 30, 2024
@ansd
Delete leftover code
011e52f 
This code should have been deleted as part of
#11642
@ansd ansd mentioned this pull request Jul 30, 2024
Merged
ansd added a commit that referenced this pull request Jul 30, 2024
@ansd
Delete leftover code
4e3ff2c 
This code should have been deleted as part of
#11642
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
@ansd @mergify
Delete leftover code
8228065 
This code should have been deleted as part of
#11642

(cherry picked from commit 4e3ff2c)
@mergify mergify bot mentioned this pull request Jul 30, 2024
Merged
ansd added a commit that referenced this pull request Jul 30, 2024
@ansd
Delete leftover code
0c9195a 
This code should have been deleted as part of
#11642

(cherry picked from commit 4e3ff2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acogoluegnes acogoluegnes acogoluegnes approved these changes

Assignees
No one assigned
Labels
bazel make
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ansd @acogoluegnes