Skip to content

Queues with plugins - Managment UI parts #13910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented May 18, 2025

Proposed Changes

This PR refactors various Management UI templates to allow dispatching by queues type. This includes node statistics.
All relevant templates/options listed in the new QUEUE_TYPE array. Statistics handled via MEMORY_STATISTICS and BINARY_STATISTICS.

Adding a new queues type then is a matter of doing QUEUE_TYPE[] = {} and patching *_STATISTICS

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Dependencies

#13905 and #13909

@ikavgo ikavgo requested a review from michaelklishin May 18, 2025 21:37
@ikavgo ikavgo force-pushed the ik-queues-with-plugins-mgmt branch from 7a647c7 to 180e7b1 Compare May 18, 2025 21:53
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 19, 2025
@michaelklishin michaelklishin merged commit 92a4d2c into main May 19, 2025
271 checks passed
@michaelklishin michaelklishin deleted the ik-queues-with-plugins-mgmt branch May 19, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants