Skip to content

Deny amqp_filter_set_bug by default #14245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Deny amqp_filter_set_bug by default #14245

merged 2 commits into from
Jul 17, 2025

Conversation

ansd
Copy link
Member

@ansd ansd commented Jul 17, 2025

The deprecated feature flag amqp_filter_set_bug was introduced in RabbitMQ 4.1 with phase permitted_by_default.
See #12415

This commit which will land in RabbitMQ 4.2 changes the phase to denied_by_default.

The deprecated feature flag `amqp_filter_set_bug` was introduced in
RabbitMQ 4.1 with phase `permitted_by_default`.
See #12415

This commit which will land in RabbitMQ 4.2 changes the phase to `denied_by_default`.
@ansd ansd added this to the 4.2.0 milestone Jul 17, 2025
@ansd ansd self-assigned this Jul 17, 2025
Fix
```
make -C deps/rabbit ct-amqp_dotnet t=cluster_size_1:streams
```
@ansd ansd marked this pull request as ready for review July 17, 2025 10:26
@ansd ansd merged commit a43e2c5 into main Jul 17, 2025
559 of 561 checks passed
@ansd ansd deleted the amqp_filter_set_bug branch July 17, 2025 13:19
ansd added a commit that referenced this pull request Aug 11, 2025
This partially reverts
#14245.
This makes 4.2 <-> 3.13 mixed version tests succeed.
We can set this flag to `denied_by_default` in 4.3.
mkuratczyk pushed a commit that referenced this pull request Aug 11, 2025
This partially reverts
#14245.
This makes 4.2 <-> 3.13 mixed version tests succeed.
We can set this flag to `denied_by_default` in 4.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant