Skip to content

Classic queues: return basic info items without calling queue process (backport #14280) #14281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 24, 2025

Proposed Changes

This should make listing for example only names of queues in CLI faster if there are a lot of classic queues.
Quorum queues and streams already work like this.

My motivation to submit this PR now is that using info(Q, [members]) was suggested in #14241 (review), but without this PR it would cause a performance regression in case of many classic queues (and info(Q, [members]) was not even supported by classic queues on 4.0.x before 71f921c0)

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments


This is an automatic backport of pull request #14280 done by [Mergify](https://mergify.com).

This should make listing for example only names of queues faster if
there are a lot of classic queues.

(cherry picked from commit 21556b5)
@michaelklishin michaelklishin added this to the 4.1.3 milestone Jul 24, 2025
@michaelklishin michaelklishin merged commit 1f97bf3 into v4.1.x Jul 25, 2025
275 of 276 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-14280 branch July 25, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants