Skip to content

erlfmt rabbitmq_aws (which the AWS team now maintains) #14315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025

Conversation

SimonUnge
Copy link
Collaborator

Proposed Changes

A plugin wide formatting - no changes to the code other than formatting.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@SimonUnge SimonUnge requested a review from the-mikedavis July 30, 2025 20:58
@michaelklishin michaelklishin changed the title DONT MERGE WAIT FOR CLA: erlfmt entire plugin DONT MERGE WAIT FOR CLA: erlfmt rabbitmq_aws (which the AWS team now maintains) Jul 30, 2025
@lukebakken
Copy link
Collaborator

Once this is squashed and merged, don't forget to add the commit to this file - https://github.com/rabbitmq/rabbitmq-server/blob/main/.git-blame-ignore-revs

@the-mikedavis
Copy link
Collaborator

Like #7067 I wonder if we can include that .git-blame-ignore-revs change in this PR? I think the merge commit won't count towards the blame.

Otherwise lgtm 👍. The erlfmt style looks a little odd to me so far but I prefer something automated than something pretty and I'm sure I'll get used to this. And I definitely like it better than the old style with 2-space columns!

@michaelklishin
Copy link
Collaborator

No objections from me either.

@michaelklishin michaelklishin changed the title DONT MERGE WAIT FOR CLA: erlfmt rabbitmq_aws (which the AWS team now maintains) erlfmt rabbitmq_aws (which the AWS team now maintains) Aug 7, 2025
@michaelklishin michaelklishin added this to the 4.2.0 milestone Aug 7, 2025
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will backport this to v4.1.x to reduce the delta with main.

@michaelklishin michaelklishin merged commit 4b823f0 into main Aug 7, 2025
834 of 837 checks passed
@michaelklishin michaelklishin deleted the su_aws/formatting_rabbitmq_aws branch August 7, 2025 01:14
@michaelklishin
Copy link
Collaborator

@SimonUnge would you like to submit a v4.1.x version of this PR, too? To keep the delta smaller since we try to backport small improvements and as many bug fixes as we can without introducing new feature flags.

The backport PR fail with lots of conflicts, so we might as well re-run erlfmt for the library in question on v4.1.x directly.

@SimonUnge SimonUnge mentioned this pull request Aug 7, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants