Initialise sequence numbers to 0 #14329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Aug 5, 2025
|
To add some context: this will allow certain systems that use amqpnetlite very heavily upgrade from |
|
This |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ MAY initialise the next-outgoing-id and delivery-count sequence numbers to arbitrary values.
For RabbitMQ 4.2, let's initialise both to 0.
This allows clients using an old amqpnetlite library (i.e. clients which haven't yet upgraded to a version containing the fixes for Azure/amqpnetlite#575 and Azure/amqpnetlite#578) to be used with RabbitMQ 4.2.