-
Notifications
You must be signed in to change notification settings - Fork 4k
Add config option for enabling local_random_exchange #14348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for enabling local_random_exchange #14348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of a few really old (circa 2015) settings that pre-date even rabbitmq.conf
, the key naming pattern for such settings is usually
{feature}.enabled = true | false
So I'd prefer
exchange_types.local_random.enabled = false
(we do not really have any similar exchange settings, except for log.exchange
but that's a stretch because it's a log setting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rabbit_exchange_type_local_random
now uses uses two different app environment keys (rabbit.local_random_exchange_enabled
, rabbit.enable_local_random_exchange
), and both application:get_env/3
and rabbit_misc:get_env/3
.
Add config option for enabling local_random_exchange (backport #14348)
Proposed Changes
This adds config option which can be used to prevent creation of local random exchanges. If RabbitMQ is behind a load balancer then local random exchanges can't be used effectively, so it would be useful for operators to set enable_local_random_exchange = false to prevent them from being created.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentCLA
This contribution is from AWS, who have signed the CLA.