Skip to content

[skip ci] Add module name to the FF debug log #14357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Conversation

mkuratczyk
Copy link
Contributor

Without this change, the logs looked confusing:

[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 23 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 2 feature flags (including deprecated features)

it wasn't clear why the same app was queried multiple times with different results.

Without this change, the logs looked confusing:
```
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 23 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 2 feature flags (including deprecated features)
```

it wasn't clear why the same app was queried multiple times with different results.
@mkuratczyk mkuratczyk merged commit 87099e8 into main Aug 11, 2025
1 check passed
@mkuratczyk mkuratczyk deleted the ff_log_module branch August 11, 2025 11:36
mergify bot pushed a commit that referenced this pull request Aug 11, 2025
Without this change, the logs looked confusing:
```
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 23 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 2 feature flags (including deprecated features)
```

it wasn't clear why the same app was queried multiple times with different results.

(cherry picked from commit 87099e8)
mkuratczyk added a commit that referenced this pull request Aug 11, 2025
Without this change, the logs looked confusing:
```
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 23 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 1 feature flags (including deprecated features)
[debug] <0.217.0> Feature flags: application `rabbit` has 2 feature flags (including deprecated features)
```

it wasn't clear why the same app was queried multiple times with different results.

(cherry picked from commit 87099e8)

Co-authored-by: Michal Kuratczyk <michal.kuratczyk@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant