Don't load ActiveStorage::Blob when validating the service #54142
+82
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fce90b to
96457eb
Compare
96457eb to
e8db8ca
Compare
For tasks like `assets:precompile` that don't need ActiveStorage, we should not be loading the entire Active Storage behavior just to be able to validate the service configuration since Active Storage might be miss configured for that task.
e8db8ca to
8b3782c
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jan 7, 2025
…-active-storage Don't load ActiveStorage::Blob when validating the service
rafaelfranca
added a commit
that referenced
this pull request
Jan 7, 2025
…-active-storage Don't load ActiveStorage::Blob when validating the service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tasks like
assets:precompilethat don't need ActiveStorage, we should not be loading the entire Active Storage behavior just to be able to validate the service configuration since Active Storage might be miss configured for that task.Fixes #54139