Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (13d7ec4) to head (f4fd710).

@@            Coverage Diff            @@
##              main      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          304       328   +24     
=========================================
+ Hits           304       328   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hey, thanks for your work!

Here's what I see from a quick first pass:

• a few things need to be cleaned:
  • no need to rewrite split_files and other utils in the examples, let's just import them
  • let's remove some comments / commented code / prints (especially those in Chinese)
  • don't depend on external libraries that are not dependencies, such as requests
• I think we should stay closer to the JS SDK and implement the formDataParams logic
• tests must be added so that we keep at least 100% coverage.

What do you think?

Thank you for your review and feedback. I highly agree with the points you raised.

In fact, my initial submission included some elements not directly related to the Notion SDK, such as split_files and mime handling, as you correctly pointed out. I will remove these from the client to align with the JavaScript SDK implementation. The PR will focus solely on the file upload feature to maintain the project's purity.

Regarding the examples, I will completely remove those extraneous parts, retaining only a minimal implementation for file uploads.

Concerning the send method in the file upload endpoints, I fully agree with your suggestion to "stay closer to the JS SDK and implement the formDataParams logic". After reconsideration, my approach will be as follows below (details).

For other cleanup items, I will clean up the redundant comments , and irrelevant dependencies.

About test coverage: I must admit I have no prior experience with this. I am actively learning and writing tests now to meet the project's high standards.

I will continue refining the code, which may take some time. I will update the PR immediately upon completion. Thank you again for your professional guidance!

def send(self, file_upload_id: str, **kwargs: Any) -> SyncAsync[Any]:
    """Send a file upload

    *[🔗 Endpoint documentation](https://developers.notion.com/reference/send-a-file-upload)*
    """  # noqa: E501
    return self.parent.request(
        path=f"file_uploads/{file_upload_id}/send",
        method="POST",
        form_data=pick(kwargs, "file", "part_number"),
        auth=kwargs.get("auth"),
    )

    def _build_request(
        self,
        method: str,
        path: str,
        query: Optional[Dict[Any, Any]] = None,
        body: Optional[Dict[Any, Any]] = None,
        form_data: Optional[Dict[Any, Any]] = None,
        auth: Optional[str] = None,
    ) -> Request:
        ...

        if form_data is not None:
            files = {}
            data = {}

            for key, value in form_data.items():
                if key == "file":
                    files[key] = value
                else:
                    data[key] = value
            return self.client.build_request(
                method,
                path,
                params=query,
                json=body,
                files=files,
                data=data,
                headers=headers,
            )
        else:
            return self.client.build_request(
                method,
                path,
                params=query,
                json=body,
                headers=headers,
            )

Hi @tsinglinrain, cool that you started to work on this feature. May I ask what the current status is?
When this PR is merged, I am hoping to implement the same feature in Ultimate Notion, which relies on notion-sdk-py. So the sooner you are ready, the sooner I can start working on a high-level implementation 😄

Hi, @FlorianWilhelm, sorry for the delay. The last commit already completed all the intended work. I had originally planned to do another round of checks for any potential issues, but I got caught up with job hunting and the related preparations, and couldn't find the time.

I'll be taking two weeks off starting tomorrow, and during that time I’ll be fully dedicating myself to finishing up this PR.

Hi @tsinglinrain, cool that you started to work on this feature. May I ask what the current status is? When this PR is merged, I am hoping to implement the same feature in Ultimate Notion, which relies on notion-sdk-py. So the sooner you are ready, the sooner I can start working on a high-level implementation 😄

Hi, when you have a moment, could you please review this PR? I believe the file upload feature is mostly done in the latest commit. There might still be some issues, and I plan to resolve them within the next two weeks.