Fix missing sonar.java.binaries configuration #265
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @rashidi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This PR addresses a missing configuration for SonarCloud analysis in the build.gradle.kts file. By adding the sonar.java.binaries property, it ensures that SonarCloud can correctly locate and analyze the compiled Java bytecode, which is crucial for accurate code quality and security scanning.
Highlights
- SonarQube Configuration Fix: I've added the sonar.java.binaries property to the build.gradle.kts file, setting its value to **/build/classes. This change is essential for SonarCloud to properly identify and analyze the compiled Java bytecode, ensuring comprehensive code quality checks.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds the sonar.java.binaries configuration, presumably to fix a SonarCloud analysis issue. While this is the right property to configure, the provided path is overly broad. My review includes a suggestion to make this configuration more robust and maintainable by dynamically collecting the binary paths from subprojects. This is a best practice for multi-module Gradle projects and will ensure the analysis is more accurate.
| @@ -34,6 +34,7 @@ sonar { | |||
| property("sonar.projectKey", "rashidi_spring-boot-tutorials") | |||
| property("sonar.organization", "rashidi-github") | |||
| property("sonar.host.url", "https://sonarcloud.io") | |||
| property("sonar.java.binaries", "**/build/classes") | |||
There was a problem hiding this comment.
Using a hardcoded path like **/build/classes is not ideal as it's brittle and can incorrectly include test classes in the SonarQube analysis, which can skew metrics like code coverage. A more robust approach is to dynamically generate the path from your subprojects' source sets. This ensures only production code binaries are included and automatically adapts to your project structure, for instance if you add Kotlin modules in the future.
property("sonar.java.binaries", subprojects.flatMap { it.sourceSets.getByName("main").output.classesDirs }.joinToString(","))
|
No description provided.