Skip to content

Conversation

JamesH65
Copy link
Contributor

Added section on DVFS

@JamesH65 JamesH65 requested review from lurch and popcornmix November 27, 2019 11:42
@JamesH65
Copy link
Contributor Author

JamesH65 commented Dec 2, 2019

I spoke to @helenlynn re: naming - although Raspberry Pi 4 Model B is officially correct, removing the Model is entirely fine.

@ghost
Copy link

ghost commented Dec 2, 2019

I spoke to @helenlynn re: naming - although Raspberry Pi 4 Model B is officially correct, removing the Model is entirely fine.

Sorry - you're quite right. The product page does indeed show all of the products with the word 'model' included. The element 14 packaging in my Pi 4B also says 'Raspberry Pi 4 Computer Model B'. I'm not sure why I thought this wasn't the case.

@ghost
Copy link

ghost commented Dec 2, 2019

Just to restate (as I deleted the original to try to tidy things up) two proposed changes to this file, in parts not altered by the changes in this PR:

  • 2nd paragraph of page: remove reference to firmware after 2016 - no longer necessary.

  • last paragraph of page: change 'gencmd' to 'command'.

@JamesH65
Copy link
Contributor Author

JamesH65 commented Dec 9, 2019

Agree with @andrum99 so have made the suggested changes. Since copy editing is taking so long, can the reviewers please comment if they want anything else changed or see typos, if nothing is spotted, I'll merge in a couple of days.

Copy link
Contributor

@popcornmix popcornmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JamesH65 JamesH65 merged commit f1df8c3 into master Dec 11, 2019
@helenlynn
Copy link

Did this one ever get the ready-for-copy-edit label added? I think I've checked over the last couple of weeks and I don't think I've seen this one. One large PR (#1333, currently with a freelancer) notwithstanding, we are (for once this year!) not currently horribly backlogged for copy-edit.

@JamesH65
Copy link
Contributor Author

No, this was CE'd by @lurch and @andrum99 directly as was vaguely urgent as the DVFS code had just been released. If necessary you can make changes on another branch then either merge directly or create another PR for technical checking.

@ghost
Copy link

ghost commented Dec 12, 2019

No, this was CE'd by @lurch and @andrum99 directly as was vaguely urgent as the DVFS code had just been released. If necessary you can make changes on another branch then either merge directly or create another PR for technical checking.

Not sure my contributions qualify as 'copy edit', more 'checking for typos' 😋

@JamesH65 JamesH65 deleted the JamesH65-patch-dvfs branch January 2, 2020 14:54
@MichaIng MichaIng mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants