Skip to content

Conversation

nelliemckesson
Copy link
Contributor

@lurch can you test this and let me know if it makes any difference?

@aallan aallan linked an issue Aug 27, 2021 that may be closed by this pull request
@aallan aallan added browser It's a browser problem. Yay. bug fix labels Aug 27, 2021
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - scrollbar when needed, no scrollbar when not-needed 👍
Screenshot from 2021-08-31 10-02-25

(tested on Google Chrome on Ubuntu Linux)

@aallan aallan marked this pull request as ready for review August 31, 2021 09:05
@aallan
Copy link
Contributor

aallan commented Aug 31, 2021

Ready to merge at that point @nelliemckesson ?

@aallan
Copy link
Contributor

aallan commented Sep 1, 2021

Also, does this also help with #1979?

@lurch
Copy link
Contributor

lurch commented Sep 1, 2021

Nope, I think this only addresses #1984 and doesn't touch on #1979

@nelliemckesson
Copy link
Contributor Author

@aallan ready to merge!

@aallan aallan merged commit dba5c29 into develop Sep 6, 2021
@aallan aallan deleted the 1984n branch September 6, 2021 09:49
@ghost
Copy link

ghost commented Sep 6, 2021

Confirmed working as intended on Chrome and Edge (Chrome-based) on Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser It's a browser problem. Yay. bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering: code sections always have a scroll bar at the bottom
3 participants