-
Notifications
You must be signed in to change notification settings - Fork 2k
conditional: Document the new expression filter and new Pi5 boot variables #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
273eb3c
to
99a19bf
Compare
99a19bf
to
70a3759
Compare
70a3759
to
601d2ff
Compare
601d2ff
to
beecdb7
Compare
documentation/asciidoc/computers/configuration/device-tree.adoc
Outdated
Show resolved
Hide resolved
beecdb7
to
649ea93
Compare
@lurch - Any more comments? |
649ea93
to
e425017
Compare
Haha, fair enough.
Sorry to keep nit-picking, but if you wanted to be consistent with the terminology on the rest of https://www.raspberrypi.com/documentation/computers/config_txt.html you'd need to use "Flagship models since Raspberry Pi 5, Compute Modules since CM5, and Keyboard models since Pi 500". |
I'm ignoring the "Pi 5 family" vs "Flagship" vs "Pi 5" changes because the documentation repo is already inconsistent and I'm not sorting out as part of this change. |
We (and third parties) often use "flagship" to mean the credit-card-sized Raspberry Pis specifically, so we shouldn't say "flagship devices only" unless we positively want to indicate that something does not apply to CMs or Raspberry Pi x00 devices. "flagship devices only" for something that also applies to CM5 and Pi 500 is inaccurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may need to update other references to flagship.
Personally I would recommend not using flagship anywhere in technical documentation because it doesn’t mean much to a typical user.
Agreed; it's rarely if ever going to be clear without additional explanation. But for now I will settle for this particular PR not adding confusion :) |
No description provided.