Add user agent string to parseUrl method #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with parent fork
Without a user agent, a surprising amount of RSS feeds will return a 400 error code
|
bump |
| var parsedUrl = url.parse(feedUrl); | ||
| var req = get({ | ||
| hostname: parsedUrl.hostname, | ||
| path: parsedUrl.path, |
There was a problem hiding this comment.
Can you add parsedUrl.search to the path if it exists? Otherwise LGTM
There was a problem hiding this comment.
The path attribute will contain the search string, if present. https://nodejs.org/api/url.html#url_urlobject_path
On Jul 11, 2016, at 10:20, Bobby Brennan notifications@github.com wrote:
In index.js:
var xml = '';
- var get = url.indexOf('https') === 0 ? HTTPS.get : HTTP.get;
- var req = get(url, function(res) {
- var get = feedUrl.indexOf('https') === 0 ? HTTPS.get : HTTP.get;
- var parsedUrl = url.parse(feedUrl);
- var req = get({
- hostname: parsedUrl.hostname,
- path: parsedUrl.path,
Can you add parsedUrl.search to the path if it exists? Otherwise LGTM—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@andjosh this would explain the 400s I was getting from mediafire pulling in an RSS feed. Once again you are ahead of the game. I suspected it may be the lack of user-agent. |
|
Released as 2.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a declared user agent, a surprising amount of RSS feeds will return a 400
error code