Skip to content

Add support for mariadb's ed25519 authentication #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: stein-rdo
Choose a base branch
from
Open

Add support for mariadb's ed25519 authentication #1

wants to merge 1 commit into from

Conversation

dciabrin
Copy link
Contributor

Include #791 [1] into the current release of PyMySQL to
support mariadb's auth_ed25519.

This patch can be dropped once the PR have landed upstream
(currently depending on a new release of pynacl [2]).

Note: this shall be consumed by Ussuri and Train releases, it
is not planned to be used by older releases.

[1] PyMySQL/PyMySQL#791
[2] pyca/pynacl#573

Related-Bug: #1868454

@dciabrin
Add support for mariadb's auth_ed25519
7314b9d 
Include #791 [1] into the current release of PyMySQL to
support mariadb's auth_ed25519.

This patch can be dropped once the PR have landed upstream
(currently depending on a new release of pynacl).

[1] PyMySQL/PyMySQL#791

Related-Bug: #1868454
@dciabrin
Copy link
Contributor Author

FYI This PR complements rdo-common/python-pynacl#1. Together with libsodium 1.0.18 they are required to implement ed25519 client authentication in Ussuri and Train.

@amoralej
Copy link
Contributor

amoralej commented Apr 1, 2020

I see upstream patch is unmerged yet. Do you think we may get it merged and push it as part of a new release soon enough?

@dciabrin
Copy link
Contributor Author

dciabrin commented Apr 1, 2020

Merging won't happen until their travis is green for that patch. And the only thing blocking it is the new pending pynacl release.
I can't predict the outcome of that PR but I'm pretty confident it will get merged eventually because it follows the same strategy as another similar PR for a different mysql's authentication plugin.
I'm pushing it ahead of time here because that's the only thing that prevent me from providing ed25519 authentication in OpenStack, which is a valuable and requested feature in the field.

@amoralej
Copy link
Contributor

amoralej commented Apr 6, 2020

I've rebased this patch on rawhide fedora on ussuri-c8-rdo branch 31de31a

this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dciabrin @amoralej