Skip to content

Perform ref forwarding in Form.Label when rendering as a Col #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2021
Merged

Perform ref forwarding in Form.Label when rendering as a Col #5835

merged 1 commit into from
May 30, 2021

Conversation

agwells
Copy link
Contributor

@agwells agwells commented May 25, 2021

When the <Form.Label> component is rendered with the prop column={true}, it doesn't forward refs. (It does forward them correctly otherwise.)

@kyletsang
Copy link
Member

Thanks for the PR. There's a conflict in the file

@agwells
Copy link
Contributor Author

agwells commented May 28, 2021

Thanks for the PR. There's a conflict in the file

Cheers, I've rebased the branch :)

@kyletsang kyletsang merged commit af24cfa into react-bootstrap:master May 30, 2021
@kyletsang
Copy link
Member

Thanks

@agwells agwells deleted the formlabel-column-ref-forwarding branch May 30, 2021 22:19
kyletsang pushed a commit that referenced this pull request Jun 3, 2021
@agwells @kyletsang
fix(FormLabel): forward ref when rendering as Col (#5835)
98b6b87
kyletsang pushed a commit that referenced this pull request Jun 3, 2021
@agwells @kyletsang
fix(FormLabel): forward ref when rendering as Col (#5835)
bb128e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agwells @kyletsang