Proposal change to the copied code #852
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
that looks good, would you like to apply to all so it's consistent? perhaps a custom hook for the job. |
|
Yeah. Make sense create for all. I'll change the PR. |
|
@bluebill1049 I created a component I change on this pages/components:
I searched the whole project and couldn't find any more alerts modal with clipboard. |
|
I fixed a small issue on Test case for this bug: |
|
thanks a lot for making this happend. 👍 |
|
Thanks you for this beautiful library! |
| className?: string | ||
| currentLanguage: string | ||
| }) => { | ||
| const [copiedCode, setCopiedCode] = useState<boolean>(false) |
There was a problem hiding this comment.
worth adding a ref with setTimeout in case of a memory leak.
const timer = useRef()
React.useEffect(() => () => clearTime(timer.current))There was a problem hiding this comment.
I will address this tho, thanks for the awesome work!
There was a problem hiding this comment.
Excellent point! Thanks so much.
Description
We are currently opening an
alertto let you know that the code has been copied. My proposal is to improve the user experience by informing on the button itself that the code is already copied in its transfer area. If this change makes sense, we create this action for the others copy buttons.BEFORE
AFTER