Don't move cursor to the top on first undo #110
Conversation
| if (record) { | ||
| // Apply the changes and update the offset | ||
| this._updateInput(record); | ||
| this._updateInput({ ...record, selectionStart, selectionEnd }); |
There was a problem hiding this comment.
I think that it could be good to keep the responsibility of _undoEdit to undo the history stack. Would it work with this logic inside _applyEdits? Otherwise, maybe simply to have before we call _undoEdit.
There was a problem hiding this comment.
I feel like applying the undo stack should not include to not corrupt the other state - so this is the right location to add the code.
_applyEdits would also record the new change (which is not wanted here).
|
This a great editor. I am glad I found this PR 👍 Saved the day! The undo jump was problematic. But, with your fix I was able to fix this behavior on a fork. Thank you 🙏 I think it's worth merging or looking into a revision if possible. Thank you all for this editor option. |
|
I also think this should have been merged. I've used this package 2 years ago (before this PR was even created) and I'm shocked this bug still exists. |
Motivation
Thanks for making and maintaining this library! We are using it for the demos on https://mui.com/. The first undo on a demo causes the cursor to reset back to the first position:
Motivation.mov
Test plan
Before:
Before.mov
After:
After.mov
Related to #38