feat: add noWrap #36
Open
feat: add noWrap #36
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@satya164 Any plans to add this feature? |
|
I checked your code on react runner and some additional CSS was necessary for me to get horizontally scrolling working:
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I managed to make the editor scrollable horizontally, see https://nihgwu.github.io/react-runner/, but it's kind of hacky, as there is no way to set the inner elements' style via props, so I have to add
!importantto override the default style here https://github.com/nihgwu/react-runner/blob/master/website/src/components/LiveRunner.js#L37Another options is change this line to
whiteSpace: 'inherit',and movewhiteSpace: 'pre-wrap',to the container section, so I can override it viastylewithout!importantTest plan