Override default styles with styles from language #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a very clean fix, @karlhorky. Would you consider this "breaking," in the same way that #305 was "breaking" by causing a long-broken thing to start working? Or do you anticipate most users perceiving this as a bugfix? |
|
Good question. I suppose I would see it as a semver minor (not just a patch), because:
So |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styles from
prism-themes@1.4.1have been updated in #313 (thanks @simmerer!). And due to #305, they are using more nested token styles.However, they are missing some default styling (eg. JavaScript code blocks should have
#9cdcfeas the default color), which I have found to be a limitation ofreact-syntax-highlighter. The default styles for a theme are not being overridden by those by the current language.This pull request is a possible solution to that issue.