Address code wrapping visual issue when both wrapLongLines and showLineNumbers are set to true #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re both on - When both the wrapLongLines and showLineNumbers props are turned on, if the code text is long enough to wrap, the `display: flex` on the wrapping span forces all its children to be equal height. Nesting the children one layer deep ensures that the line number aligns with the rest of the code in that line nicer.
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 95.97% 95.10% -0.87%
==========================================
Files 11 11
Lines 323 327 +4
Branches 123 125 +2
==========================================
+ Hits 310 311 +1
- Misses 12 14 +2
- Partials 1 2 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is in response to #376 where when both
wrapLongLinesandshowLineNumbersare set to true, the UI sometimes breaks. This issue is more prominent the smaller the viewport is.It does the following:
Adds
word-break: break-word;along sidewhite-space: pre-wrap;to address the horizontal scroll bar introduced by a long path (as mentioned on Code wrapping breaks when wrapLongLines and showLineNumbers are set #376 (comment))Before:
After:
It addresses the code misalignment introduced by
display:flex;on the parentspanby nesting the code one layer deeper.Please see a screencast of the comparisons below:
Before:
syntax-highlighter-before.mov
After:
syntax-highlighter-after.mov
Any feedback welcome, thanks!