This repository was archived by the owner on Jul 19, 2019. It is now read-only.
added permissive CORS header middleware function #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| app.use(function(req, res, next) { | ||
| //set permissive CORS headers | ||
| res.setHeader('Access-Control-Allow-Origin', '*'); | ||
| res.setHeader('Access-Control-Allow-Methods', 'GET,OPTIONS,HEAD,PUT,POST,DELETE,PATCH'); |
There was a problem hiding this comment.
Do you really need all of these? I would think that just Access-Control-Allow-Origin is all you need.
There was a problem hiding this comment.
I agree, except I believe that the preflight is also needed for POST? so I could remove the method and headers lines.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS
There was a problem hiding this comment.
after testing, I couldn't recreate this scenario with Firefox or chromium, so i remove the extra statements per your suggestion
zpao
added a commit
that referenced
this pull request
Jan 26, 2016
added permissive CORS header middleware function
|
Squashed and pushed as 3fba2d4. Thanks! |
|
thanks for maintaining the tutorial! enjoyed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again... terribly sorry for causing noise and opening a new issue, I just had ran into a problem squashing the commits.
previous discussion:
#118