Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Set no-cache header #37

Merged
merged 1 commit into from
Mar 1, 2015
Merged

Set no-cache header #37

merged 1 commit into from
Mar 1, 2015

Conversation

zpao
Copy link
Member

@zpao zpao commented Feb 27, 2015

Supersedes #35 (this does all the server implementations, not just the node one).

@@ -81,5 +87,6 @@ func handleComments(w http.ResponseWriter, r *http.Request) {
func main() {
http.HandleFunc("/comments.json", handleComments)
http.Handle("/", http.FileServer(http.Dir("./public")))
log.Println("Server started: http://localhost:3000")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't ListenAndServe fail, making this confusing? ah well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, though it logs that it fails. Perhaps I can say "Starting server…" but it's not a huge deal.

2015/03/01 12:00:04 Server started: http://localhost:3000
2015/03/01 12:00:04 listen tcp :3000: bind: address already in use
exit status 1

@sophiebits
Copy link
Member

lgtm

@zpao zpao mentioned this pull request Mar 1, 2015
zpao added a commit that referenced this pull request Mar 1, 2015
@zpao zpao merged commit 13a46a2 into reactjs:master Mar 1, 2015
@zpao zpao deleted the no-cache branch March 11, 2015 18:40
shenxl pushed a commit to shenxl/react-tutorial that referenced this pull request Sep 15, 2015
Update 03_about-state-and-meet-redux.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants