Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Restful endpoints #48

Closed
wants to merge 3 commits into from
Closed

Conversation

malditogeek
Copy link

As suggested on #39 and facebook/react#3391

👍

@malditogeek
Copy link
Author

I personally would change https://github.com/reactjs/react-tutorial/blob/master/public/scripts/example.js#L123 to be <CommentBox resource="comments.json" pollInterval={2000} /> but I'm new to React so I'm not sure if url property is a convention or can be anything.

What do you think @zpao ?

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Apr 22, 2015

This looks great, thanks! I'm going to hold off on merging until we get the tutorial on the site ready to go (which I think needs a bit more work than just updating the code - we should make the need for a server even more obvious).

@zpao
Copy link
Member

zpao commented Sep 26, 2015

Going to close in favor of #79 and coordinate the tutorial update with that. Sorry I let this sit for so long!

@zpao zpao closed this Sep 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants