Added error handling #95
Conversation
| @@ -26,6 +26,7 @@ app.use(bodyParser.urlencoded({extended: true})); | |||
|
|
|||
| app.get('/api/comments', function(req, res) { | |||
| fs.readFile(COMMENTS_FILE, function(err, data) { | |||
| if (err) console.log(err); | |||
There was a problem hiding this comment.
Please use blocks (with curlies). And perhaps uses console.error. We should perhaps actually handle the error though. Otherwise we might just get another error when we call JSON.parse.
If we're going to say we're handling the error, let's handle them all and not just log.
Personally I don't care terribly - these are only meant to be good enough, not production ready. If you'd like to make this versatile, feel free.
There was a problem hiding this comment.
@zpao Thank you for the input. I completely agree that it is not a huge deal as it's not meant to be production ready code, and that adding extensive error handling may result in unneeded code bloating. I made some edits based on your suggestions.
|
The nuclear option, I like it :) Thanks! |
|
@zpao Thank you! |
Just added some error handling.