Skip to content

Run tests on PHP 7.4 and simplify test matrix #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2020
Merged

Run tests on PHP 7.4 and simplify test matrix #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f509da1
Install from source to actually run any tests (excluded otherwise)
clue Jul 1, 2020
57ac1c9
Upgrade react/socket to avoid skipping DNS tests
clue Mar 22, 2020
52f330e
Run tests on PHP 7.4 and simplify test matrix
clue Jul 10, 2020
40d469f
Skip affected test cases to avoid bogus test failure on PHP 7.4
clue Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,23 @@
language: php

php:
# - 5.3 # requires old distro, see below
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm

# lock distro so new future defaults will not break the build
dist: trusty

matrix:
include:
- php: 5.3
dist: precise
- php: 5.4
- php: 5.5
- php: 5.6
- php: 7.0
- php: 7.1
- php: 7.2
- php: 7.3
- php: 7.4
- php: hhvm-3.18
allow_failures:
- php: hhvm
- php: hhvm-3.18

install:
- composer install --no-interaction
Expand Down
14 changes: 10 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,22 @@
"require": {
"php": ">=5.3.8",
"react/cache": "^1.0",
"react/dns": "^1.0",
"react/dns": "^1.3",
"react/event-loop": "^1.0",
"react/promise": "^2.1 || ^1.2",
"react/promise-stream": "^1.1.1",
"react/socket": "^1.0",
"react/promise-timer": "^1.6",
"react/socket": "^1.4",
"react/stream": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^5.7 || ^4.8.35",
"clue/block-react": "^1.1",
"clue/stream-filter": "^1.3"
"clue/stream-filter": "^1.3",
"phpunit/phpunit": "^7.0 || ^6.0 || ^5.7 || ^4.8.35"
},
"config": {
"preferred-install": {
"react/*": "source"
}
}
}
21 changes: 6 additions & 15 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>

<phpunit backupGlobals="false"
backupStaticAttributes="false"
colors="true"
convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false"
syntaxCheck="false"
bootstrap="tests/bootstrap.php"
>
<phpunit bootstrap="tests/bootstrap.php" colors="true">
<testsuites>
<testsuite name="React Test Suite">
<testsuite name="ReactPHP Test Suite">
<directory>./vendor/react/*/tests/</directory>
<!-- temporarily skip broken tests, see https://github.com/reactphp/socket/issues/207 -->
<exclude>./vendor/react/socket/tests/ConnectorTest.php</exclude>
<exclude>./vendor/react/socket/tests/DnsConnectorTest.php</exclude>
<!-- temporarily skip broken tests, see https://github.com/reactphp/dns/pull/164 -->
<exclude>./vendor/react/dns/tests/FunctionalResolverTest.php</exclude>
<exclude>./vendor/react/dns/tests/Query/CoopExecutorTest.php</exclude>
<exclude>./vendor/react/dns/tests/Query/SelectiveTransportExecutorTest.php</exclude>
</testsuite>
</testsuites>

Expand Down