-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Added virtual environment enforcing for pip for the osx installation tutorial #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is great! But, let's move this out of the installation guide, and create a new section: "Pip & Virtualenv: Next Steps" (or something). We can link to it from the bottom of each installation guide! |
Great, I'll do that as soon as I'm done with school stuff :) |
I'm very excited for you to finish this @canibanoglu |
@canibanoglu me too ;) |
I am terribly sorry this took such a long time. But I did graduate finally and I will be around for any subsequent work. I have created a new file and moved the new section from the previous PR to this new file. I haven't yet added the links from the installation files, I will as soon as I get the thumbs up from you. Another thing that I am planning to do is to look around and find out how this can be done on Windows and test it before adding it to the PR. I have just one question though. How am I supposed to use the Makefile to build the docs so I can view them locally? Which also reminds me that perhaps the project could do with a contributing section? But that's for another ticket, I guess. |
@canibanoglu there's a style guide for the guide but there is no instructions to set up the repository because it is just a Sphinx project, i.e., |
Bah, thank you very much for that, that's very thick of me, Makefile --> make... I'll have to fix some stuff, code blocks are not rendered in the build. |
@canibanoglu let me know when you want me to review it. :) |
@sigmavirus24 Will do, just trying to find more info on how to do this on Windows. There is a way of doing it with |
@sigmavirus24 Could you please take a look at the language before I add the links to the installation pages? I have somehow managed to mess up the git history... I could not find a way of adding a global pip command on Windows though. Thanks a ton for all your help. |
@canibanoglu If you want, you can do a rebase to pull out Anatoly's commits. Something like ~$ git rebase -i HEAD..2c48b39 Should allow you to delete those three commits (just remove the lines with those commits). I'll look at the language for your stuff though. :) |
@canibanoglu this read really well. Did you merge master into your branch? If so it seems like you did something really weird in doing so. If you only keep the commits that you wrote you should be fine. Your branch was mergeable before. |
Alright, cleaned up the commit history and removed the horizontal line from the end of the file. Hope this is good :) |
Added virtual environment enforcing for pip for the osx installation tutorial
Thanks @canibanoglu ! 🍰 |
This fixes #335. Added a section about configuring pip so that it only installs packages when a virtual environment is active.