Improvements to the JSON section #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As with before if anyone can review this I would be very grateful! |
| @@ -1,33 +1,39 @@ | |||
| JSON parsing | |||
| JSON | |||
| =========== | |||
There was a problem hiding this comment.
The number of =s should match the length of the title.
|
@sigmavirus24 Thanks for reviewing looking at the comments now |
|
Updated based on your feedback @sigmavirus24 :) |
|
Thanks @royka |
|
Thanks very much @sigmavirus24 |
Merged
|
@sigmavirus24 should we merge this? |
|
@kennethreitz it is merged already? |
|
@sigmavirus24 @kennethreitz I think it has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging my first PR @kennethreitz !
sorry for leaving my original PR hanging after it had been reviewed
I've done some more improvements to the section with help from mplewis (https://github.com/mplewis )