Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zhangya/readme #1462

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Zhangya/readme #1462

merged 2 commits into from
Jun 25, 2021

Conversation

YanZhangADS
Copy link
Collaborator

Description

The main issue I had when setting up conda environment in my DSVM include: (1) need to "unset SPARK_HOME", and (2) export JAVA_HOME="/usr/lib/jvm/java-8-openjdk-amd64"

I am not sure if we should have a dedicated readme page for DSVM users or not.

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro
miguelgfierro approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks

@miguelgfierro miguelgfierro merged commit d70f09a into staging Jun 25, 2021
@miguelgfierro miguelgfierro deleted the zhangya/readme branch June 25, 2021 13:01
@miguelgfierro
Copy link
Collaborator

There is a very weird thing happening, when we modify a readme, only these two tests fire:

dsvm_notebook_linux_gpu #20210624.1 succeeded
dsvm_unit_linux_cpu #20210624.1 succeeded

however, no unit test should fire.

The code responsible for scheduling is the same in all unit tests:
https://github.com/microsoft/recommenders/blob/main/tests/ci/azure_pipeline_test/dsvm_notebook_linux_gpu.yml
vs
https://github.com/microsoft/recommenders/blob/main/tests/ci/azure_pipeline_test/dsvm_unit_linux_gpu.yml

Something I thought is that there might be some configuration we are not seeing in the portal, but I checked, and I couldn't find anything scheduled. Do you have any ideas @gramhagen, @anargyri, @YanZhangADS?

anargyri
anargyri reviewed Jun 28, 2021
View reviewed changes
README.md
@@ -46,6 +46,7 @@ On Windows you will need [Microsoft C++ Build Tools](https://visualstudio.micros
2. Install the package from [PyPI](https://pypi.org):

```bash
conda create -n my_environment_name python=3.6
Copy link
Collaborator

@anargyri anargyri Jun 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for this line?

  1. we don't depend on conda, the user may prefer venv
  2. the version need not be 3.6, it could be 3.7 (and we say this a couple of lines above)
  3. it is incomplete anyway (conda activate missing).

@anargyri
Copy link
Collaborator

There is a very weird thing happening, when we modify a readme, only these two tests fire:

dsvm_notebook_linux_gpu #20210624.1 succeeded
dsvm_unit_linux_cpu #20210624.1 succeeded

however, no unit test should fire.

The code responsible for scheduling is the same in all unit tests:
https://github.com/microsoft/recommenders/blob/main/tests/ci/azure_pipeline_test/dsvm_notebook_linux_gpu.yml
vs
https://github.com/microsoft/recommenders/blob/main/tests/ci/azure_pipeline_test/dsvm_unit_linux_gpu.yml

Something I thought is that there might be some configuration we are not seeing in the portal, but I checked, and I couldn't find anything scheduled. Do you have any ideas @gramhagen, @anargyri, @YanZhangADS?

Have you tried with *.md instead of specifying explicitly each filename?

@miguelgfierro
Copy link
Collaborator

Have you tried with *.md instead of specifying explicitly each filename?

It didn't work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri left review comments

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen gramhagen approved these changes

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YanZhangADS @miguelgfierro @anargyri @gramhagen