Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danb27/sar literal fix #1663

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Danb27/sar literal fix #1663

merged 3 commits into from
Mar 9, 2022

Conversation

danb27
Copy link
Contributor

@danb27 danb27 commented Mar 8, 2022

Description

Change how the package checks for similarity type from 'is' to ==
This is more correct python code - check for the same value in the string using ==, avoids problems when unpacking parameters from other files using json package.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@ghost
Copy link

ghost commented Mar 8, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@danb27
Copy link
Contributor Author

danb27 commented Mar 8, 2022

More information on the problem with using 'is': https://lerner.co.il/2015/06/16/why-you-should-almost-never-use-is-in-python/

gramhagen
gramhagen approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

miguelgfierro
miguelgfierro approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@miguelgfierro miguelgfierro merged commit 60426b4 into recommenders-team:staging Mar 9, 2022
@miguelgfierro
Copy link
Collaborator

hey @danb27 I have just realized that you haven't signed your commits, so your name won't appear on GitHub. If you want to keep contributing to the repo and that your name appears on it, you can sign your commits following: https://github.com/microsoft/recommenders/wiki/How-to-add-your-name-as-a-contributor-to-the-repo#make-sure-that-your-github-user-is-setup-correctly

git config --global user.name "Your Name"
git config --global user.email your-github-username@users.noreply.github.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen gramhagen approved these changes

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danb27 @miguelgfierro @gramhagen