fix(coderd): avoid deadlock in (*logFollower).follow (coder#7983)

mafredri · web-flow · commit 4068f70d2b0c · 2023-06-12T18:38:46.000Z
diff --git a/coderd/provisionerjobs.go b/coderd/provisionerjobs.go
@@ -318,6 +318,10 @@ func (f *logFollower) follow() {
 			return
 		}
 		defer subCancel()
+		// Move cancel up the stack so it happens before unsubscribing,
+		// otherwise we can end up in a deadlock due to how the
+		// in-memory pubsub does mutex locking on send/unsubscribe.
+		defer cancel()
 
 		// we were provided `complete` prior to starting this subscription, so
 		// we also need to check whether the job is now complete, in case the
