fix(coderd): avoid deadlock in (*logFollower).follow
#7983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(*logFollower).follow(*logFollower).follow
Emyrk
approved these changes
Jun 12, 2023
|
Amazing find! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/coder/coder/actions/runs/5246409984/jobs/9475217767?pr=7934
This is mostly an issue due to in memory pubsub, I doubt it is with postgres, but I could be wrong.
We should re-write publish in the in memory pubsub so that the mutex is not held while calling listeners, but we still need to prevent multiple concurrent calls to them (and ensure order).