[RemoveTestSuffixFromAbstractTestClassesRector] Add new rule (#132) #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 5, 2023
| $classShortName = $this->nodeNameResolver->getShortName($className); | ||
| // no match → rename file | ||
| $newFileLocation = dirname($filePath) . DIRECTORY_SEPARATOR . $classShortName . 'Case.php'; | ||
| $this->removedAndAddedFilesCollector->addMovedFile($this->file, $newFileLocation); |
There was a problem hiding this comment.
Is there a way i can use RenameClassRector to rename the class/file here?
ghost
reviewed
Jan 5, 2023
|
|
||
| private function getPhpUnitDirectorySuffix(): string | ||
| { | ||
| // TODO check in phpunit config if this is different. |
There was a problem hiding this comment.
Are there example on how i can read the phpunit config file?
|
@samsonasik if you have time could you give me some hits for #141 (comment) & #141 (comment) |
@samsonasik sorry to bother you, but if you have time could you help me out or is there someone else you know who can help me out? |
|
I'll give this a priority today 👍 |
|
Continues in #151 Thanks for the kick off 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132