Skip to content

[Naming] Skip protected property on non-final class on RenamePropertyToMatchTypeRector #6872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

[Naming] Skip protected property on non-final class on RenamePropertyToMatchTypeRector #6872

merged 4 commits into from
Apr 30, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @VincentLanglet

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 91d644b into main Apr 30, 2025
45 checks passed
@samsonasik samsonasik deleted the skip-prot branch April 30, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RenamePropertyToMatchTypeRector should skip public properties to preserve public API
2 participants
@samsonasik @actions-user