Skip to content

[Php85] Add ArrayKeyExistsNullToEmptyStringRector #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 28, 2025
Merged

[Php85] Add ArrayKeyExistsNullToEmptyStringRector #7183

merged 14 commits into from
Aug 28, 2025

Conversation

arshidkv12
Copy link
Contributor

samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
samsonasik
samsonasik requested changes Aug 28, 2025
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run:

bin/rector && composer fix-cs

to fix CI

@samsonasik samsonasik changed the title Add Rector to replace null keys in array_key_exists with empty string [Php85] Add ArrayKeyExistsNullToEmptyStringRector Aug 28, 2025
samsonasik
samsonasik approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@TomasVotruba
Copy link
Member

TomasVotruba commented Aug 28, 2025 •
edited
Loading

LGTM 👍 Thank you @arshidkv12

@TomasVotruba TomasVotruba merged commit aeb8a67 into rectorphp:main Aug 28, 2025
49 checks passed
@arshidkv12
Copy link
Contributor Author

Thanks for the quick review.

@samsonasik
Copy link
Member

key seems can be int, I will check and ensure it not casted to string

https://3v4l.org/ZcBbZ

@samsonasik samsonasik mentioned this pull request Aug 28, 2025
Merged
@samsonasik
Copy link
Member

#7189

@samsonasik
Copy link
Member

Btw, the deprecation is not yet merged on php-src:

so if in the PR not merged (likely will be merged) when php 8.5 released, we can revert this rule :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arshidkv12 @TomasVotruba @samsonasik