Fixes #278

What is the best way to remove the function call to ->createView()? I can make a rule in class method and check if it has a render function call that contains form?

1. Check arguments of AbstractController::render()
2. Check if argument is an instance of FormInstance
3. Remove ->createView() from argument

However, doing it this way might not update implementations like:

$form = $contactForm->createView();
return $this->render('template.html.twig', [
    'contact_form' => $form,
];

But I think it'll be safer to limit this feature to update calls within the render() method only.

@stefantalen i agree, and the implementation like you mention also still works

Let me know when this is ready.

The createView() removal will indeed need a custom rule. The conditions list seem valid.

Please run:

vendor/bin/rector && composer fix-cs 

to make CI green.

You can verify phpstan with run:

composer phpstan

@samsonasik its ready now :)

@TomasVotruba its ready

Note i added a bit more rules

Thank you 👏