Rewatch windows support #7477
Merged
Rewatch windows support #7477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7523e6c to
94a8133
Compare
fix Fix some issues Fix issue
fix merge issue
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
This reverts commit 2c23b76.
This reverts commit 5d935a9.
cknitt
reviewed
Jun 2, 2025
| @@ -98,6 +98,9 @@ jobs: | |||
| - name: Install npm packages | |||
| run: yarn install | |||
|
|
|||
| - name: Install testrepo deps | |||
| run: cd rewatch/testrepo && yarn install | |||
There was a problem hiding this comment.
Ideally rewatch/testrepo should be added to the yarn workspaces, then we wouldn't need this. We can look into that in a separate PR though.
There was a problem hiding this comment.
Behavior is slightly different then. It's better to have a separate independent workspace for testing. If we add it to the monorepo, the dependencies would be hoisted to the rescript root, so we have a monorepo inside a monorepo.
|
I just fired up the old Windows gall. Both worked fine for me, ship it! |
cknitt
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.