Rename functions ending with Exn to OrThrow
#7518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know what you think of the change |
|
Next step is |
|
@DZakh analysis tests are failing, I think you need to make some adaptation in analysis for the new function names. |
|
Hm, messed up |
DZakh
commented
May 28, 2025
Comment on lines
98
to
107
|
|
||
| Exception Analysis | ||
| StdlibTest.res:11:5-23 | ||
| bigIntFromStringExn raises nothing and is annotated with redundant @raises(JsExn) | ||
|
|
||
| Exception Analysis | ||
| StdlibTest.res:14:5-16 | ||
| jsonParseExn raises nothing and is annotated with redundant @raises(JsExn) | ||
|
|
||
| Analysis reported 24 issues (Exception Analysis:24) | ||
| Analysis reported 26 issues (Exception Analysis:26) |
There was a problem hiding this comment.
I don't understand why it changed
There was a problem hiding this comment.
@DZakh I think you need to adapt this:
rescript/analysis/reanalyze/src/ExnLib.ml
Line 53 in 352fa02
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
|
@cknitt Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.