Update @rescript/react dependency in workspace and use it for more tests #7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, disadvantage of that is that the packages under |
This reverts commit 3bb883d. # Conflicts: # yarn.lock
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-x64
@rescript/linux-arm64
@rescript/win32-x64
commit: |
|
@zth Do you have any idea what may be causing the changes in the analysis test output? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add latest @rescript/react to packages/react and the yarn workspace and use it in tests, analysis tests, tools_tests, gentype_tests.
This is not meant to replace the separate repo https://github.com/rescript-lang/rescript-react though, we'd still do @rescript/react releases from there to be able to release versions independently from compiler versions.
There was already a copy intests/dependencies, too, but I think the location underpackagesis more prominent.